Fix key extraction logic for handling 'get' keyword in keys#7
Closed
Sudeep10 wants to merge 1 commit intojustprodev:mainfrom
Closed
Fix key extraction logic for handling 'get' keyword in keys#7Sudeep10 wants to merge 1 commit intojustprodev:mainfrom
Sudeep10 wants to merge 1 commit intojustprodev:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the localization remote-wrapper generator to correctly extract getter keys when the key name itself contains the substring get (e.g., widgetTitle), preventing truncated keys during code generation.
Changes:
- Reworked getter key extraction to avoid splitting on the substring
getwithin key names. - Switched getter parsing to use substring slicing from the
getkeyword onward.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
justprodev
added a commit
that referenced
this pull request
May 2, 2026
Owner
|
closed in favor of #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where keys containing "get" keyword were extracted incorrectly, for example
widgetTitlewas incorrectly extracted aswid